Re: tp-smapi module dkms install error with grsecurity patched

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: tp-smapi module dkms install error with grsecurity patched

Sean Behan
Hey Evgeni,

That seemed to work

Thank you :)

Sean

On Sun, Jul 17, 2016 at 12:01:01PM +0200, [hidden email] wrote:

> Send Linux-Thinkpad mailing list submissions to
> [hidden email]
>
> To subscribe or unsubscribe via the World Wide Web, visit
> http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad
> or, via email, send a message with subject or body 'help' to
> [hidden email]
>
> You can reach the person managing the list at
> [hidden email]
>
> When replying, please edit your Subject line so it is more specific
> than "Re: Contents of Linux-Thinkpad digest..."
>
>
> Today's Topics:
>
>    1. Re: tp-smapi module dkms install error with grsecurity patched
>        kernel (Evgeni Golov)
>
> --__--__--
>
> Message: 1
> Date: Sat, 16 Jul 2016 13:24:11 +0200
> From: Evgeni Golov <[hidden email]>
> To: [hidden email]
> Subject: Re: [ltp] tp-smapi module dkms install error with grsecurity patched
>  kernel
> Reply-To: [hidden email]
>
> Hi Sean,
>
> On Sat, Jul 16, 2016 at 01:47:02AM -0400, Sean Behan wrote:
>
> > /var/lib/dkms/tp_smapi-dkms/0.42/build/hdaps.c:738:33: error: constified variable ‘hdaps_whitelist’ placed into writable section ".init.data"
> >  struct dmi_system_id __initdata hdaps_whitelist[] = {
>
> Can you try the following patch please?
>
> --- a/hdaps.c
> +++ b/hdaps.c
> @@ -735,7 +735,7 @@ static int __init hdaps_dmi_match_invert(const struct dmi_system_id *id)
>     Note that HDAPS_DMI_MATCH_NORMAL("ThinkPad T42") would match
>     "ThinkPad T42p", and enumeration stops after first match,
>     so the order of the entries matters. */
> -struct dmi_system_id __initdata hdaps_whitelist[] = {
> +struct dmi_system_id __initconst hdaps_whitelist[] = {
>         HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad R50p", HDAPS_ORIENT_INVERT_XY),
>         HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad R60", HDAPS_ORIENT_INVERT_XY),
>         HDAPS_DMI_MATCH_INVERT("IBM", "ThinkPad T41p", HDAPS_ORIENT_INVERT_XY),
>
> Basically just change __initdata to __initconst.
>
> Greets
> Evgeni
>
>
>
>
>
> --__--__--
>
> --
> The linux-thinkpad mailing list home page is at:
> http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad
>
> End of Linux-Thinkpad Digest

signature.asc (836 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: tp-smapi module dkms install error with grsecurity patched

Evgeni Golov-3
Hi Sean,

On Sat, Jul 23, 2016 at 01:09:38AM -0400, Sean Behan wrote:
> That seemed to work
>
> Thank you :)

Thanks for testing, pushed upstream: https://github.com/evgeni/tp_smapi/commit/555fdb6c

Greets
Evgeni
--
The linux-thinkpad mailing list home page is at:
http://mailman.linux-thinkpad.org/mailman/listinfo/linux-thinkpad
Loading...